Conversation
Codecov Report
@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40
Lines 14773 14707 -66
==========================================
- Hits 11576 11512 -64
- Misses 2509 2515 +6
+ Partials 688 680 -8 |
kennytm
left a comment
kennytm
left a comment
There was a problem hiding this comment.
Rest LGTM.
Why do we support GBK rather than its superset GB18030?
Co-Authored-By: kennytm <kennytm@gmail.com>
@kennytm Because we just met |
tangenta
changed the title
|
PTAL @bb7133 @wjhuang2016 |
wjhuang2016
left a comment
wjhuang2016
left a comment
There was a problem hiding this comment.
GetSupportedCharsets need to change too.
Co-Authored-By: tangenta <tangenta@126.com>
|
@wjhuang2016 PTAL :) |
|
@spongedu: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 73b534d to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #808 +/- ##
==========================================
- Coverage 78.35% 78.27% -0.09%
==========================================
Files 40 40
Lines 14773 14707 -66
==========================================
- Hits 11576 11512 -64
- Misses 2509 2515 +6
+ Partials 688 680 -8 🚀 New features to boost your workflow:
|
8 participants
What problem does this PR solve?
We're using parser to develop some our systems and found that charset gbk is not supported yet in parser, which makes some SQL fail to work.
As a MySQL compatible parser, I think we should support gbk as MySQL's parser do, and leave the charset-compatible issues to
TiDBlayer.What is changed and how it works?
Add gbk into supported charsets, and add related tests
Check List
Tests